Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Client.wait_compute_plan #327

Merged
merged 4 commits into from
Jun 30, 2023
Merged

chore: use Client.wait_compute_plan #327

merged 4 commits into from
Jun 30, 2023

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Jun 27, 2023 •
edited
Loading

Related issue

Summary

Centralize wait_task and wait_compute_plan, and re-use the implementation added in substra through the other components.

Notes

Fixes FL-1052

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

@guilhem-barthes
chore: use Client.wait_compute_plan
8dcd08f 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
This was referenced Jun 27, 2023
Merged
Merged
Merged
@linear
Copy link

linear bot commented Jun 27, 2023

FL-1052 move `wait_task` & `wait_compute_plan`

Context

Currently we have 3 imlementations to wait for compute tasks/ compute plans:

Specification

Acceptance criteria

Having these features defined once in substra and the previous implementations removed.

@guilhem-barthes
docs: changelog
4394b49 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes marked this pull request as ready for review June 28, 2023 08:19
@guilhem-barthes
fix: apply feedback
983c46a 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
ThibaultFy
ThibaultFy approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better thanks :)

@guilhem-barthes
chore: remove leftover import time
812651a 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes guilhem-barthes merged commit 2827b78 into main Jun 30, 2023
2 checks passed
@guilhem-barthes guilhem-barthes deleted the chore/centralize-wait_task-in-substrasdk branch June 30, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

@oleobal oleobal oleobal approved these changes

@RomainGoussault RomainGoussault Awaiting requested review from RomainGoussault RomainGoussault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @oleobal @ThibaultFy